Feature Request: Show warning during iOS build with missing .xcconfig

Abierto
#3,760 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
ios, javascript
Área
build-system, cli, mobile

Línea de trabajo

Empieza localizando el manejo de builds de iOS en la CLI y busca referencias a build.xcconfig o a la configuración de ASSETCATALOG_COMPILER. Reproduce un build con el archivo ausente, determina después dónde debería aparecer una advertencia y verifica que la advertencia se muestre sin cambiar los builds en los que el archivo existe.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

build feature os: ios
Did you verify this is a real problem by searching the NativeScript Forum and the other open issues in this repo?

Yes

Tell us about the problem

Please, ensure your title is less than 63 characters long and starts with a capital
letter.

Which platform(s) does your issue occur on?

iOS

Please provide the following version numbers that your issue occurs with:
  • CLI: 4.2.0-2018-07-12-11970 (next)
    Project is using 4.1.0
Please tell us how to recreate the issue in as much detail as possible.

At some time in previous release, maybe NS 2 or 3x projects provided a build.xcconfig file which specifies:

ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;

for the app icons during a build which works great. However, if this file is deleted (happened on a project today and took hours to figure out why the icons weren't showing when installing the app), then the app icon is not set during a build and no warnings/info is provided.

This could be a potential time saver for others in the future if the file is not found. I don't know all the implications of that file during xcode builds so I won't pretend to 😄 - it would have saved me several hours tracking down the file was deleted months ago from the project repository and that I had to set the icons in xcode on the build settings page after opening the workspace.

Lenguaje dominante
JavaScript
Estrellas
1.1k
Forks
204
Merge medio
1 d 9 h
PR fusionados (30 d)
8

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NativeScript/nativescript-cli

Todos los issues de NativeScript/nativescript-cli

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.