envoyproxy / envoyproxy/nighthawk
Consumers of OutputFormatter::formatProto should handle NH exceptions
未关闭
- 主要语言
- C++
- 星标
- 414
- 派生
- 95
- 平均合并
- 2 天 9 小时
- 30 天内合并 PR
- 11
描述
When an execution results in a dataset that isn't able to provide all required fields to produce a valid instance of the requested output format, it's reasonable to throw.
Consumers [1] are currently not expecting this, and should be modified to catch those and handle them.
[1]
https://github.com/envoyproxy/nighthawk/blob/481ecbe4ec03184c19c630bbef8a97a6c2d11e8a/source/client/service_impl.cc#L42
https://github.com/envoyproxy/nighthawk/blob/481ecbe4ec03184c19c630bbef8a97a6c2d11e8a/source/client/client.cc#L55
贡献指南
评估
这个 Issue 还没有评估数据。