envoyproxy / envoyproxy/nighthawk

Stop excluding /api/client/BUILD in check_format

Abierto
#165 1 comentario 0 reacciones 0 asignados Ver en GitHub
help wanted
Lenguaje dominante
C++
Estrellas
414
Forks
95
Merge medio
2 d 9 h
PR fusionados (30 d)
11

Descripción

We exclude `api/client/BUILD` in `check_format.sh`, because the build insists on adding

```
load("bazel:envoy_build_system.bzl", "envoy_package")
```
For this to work for `Nighthawk`, this should look like:

```
load("@envoy//bazel:envoy_build_system.bzl", "envoy_package")
```

So either having a way to pull that off, or a way to make a more narrow exclusion instead of excluding the whole file from `check_format` would be desirable.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.