envoyproxy / envoyproxy/nighthawk

Stop excluding /api/client/BUILD in check_format

Open
#165 1 comment 0 reactions 0 assignees View on GitHub
help wanted
Dominant language
C++
Stars
414
Forks
95
Avg merge
2d 9h
Merged PRs (30d)
11

Description

We exclude `api/client/BUILD` in `check_format.sh`, because the build insists on adding

```
load("bazel:envoy_build_system.bzl", "envoy_package")
```
For this to work for `Nighthawk`, this should look like:

```
load("@envoy//bazel:envoy_build_system.bzl", "envoy_package")
```

So either having a way to pull that off, or a way to make a more narrow exclusion instead of excluding the whole file from `check_format` would be desirable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.