envoyproxy / envoyproxy/gateway

replacePrefixMatch broken in main

Open
#4,331 19 comments 7 reactions 0 assignees View on GitHub
triage
Dominant language
Go
Stars
3k
Forks
864
Avg merge
2d 2h
Merged PRs (30d)
140

Description

*Description*:
>What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

with envoy gateway 1.1 I was using following spec

```
- type: URLRewrite
urlRewrite:
path:
type: ReplacePrefixMatch
replacePrefixMatch: /docs/
```

So my goal is to add `/docs/` prefix to all url paths. So it will be modified like `/docs/`.

With latest main the request path was modified only `/docs` (NOTE! missing last slash)

However, with latest main it will not add the ending slash anymore. I was forced to use

```
- type: URLRewrite
urlRewrite:
path:
type: ReplacePrefixMatch
replacePrefixMatch: /docs//
```

to get same behaviour working.

*Repro steps*:
> Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

>**Note**: If there are privacy concerns, sanitize the data prior to
sharing.

*Environment*:
>Include the environment like gateway version, envoy version and so on.

eg 1.1 (envoy 1.31) and main (with envoy distroless-devel)

*Logs*:
>Include the access logs and the Envoy logs.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.