envoyproxy / envoyproxy/gateway

Supression of X-Envoy headers breaks expected output of default log format

Ouverte
#2,903 5 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
help wanted kind/bug
Langage dominant
Go
Étoiles
3k
Forks
864
Merge moyen
2 j 2 h
PR mergées (30 j)
140

Description

*Description*:

After the changes in #2500 and #2585 logs no longer include the proper request path where path rewrites are used.

*Repro steps*:

If you apply the quickstart demo and then add a rule to the HTTPRoute:

```
- backendRefs:
- group: ""
kind: Service
name: backend
port: 3000
weight: 1
matches:
- path:
type: PathPrefix
value: /rewrite
filters:
- type: URLRewrite
urlRewrite:
path:
type: ReplacePrefixMatch
replacePrefixMatch: /123
```

This request:

```
curl -sv -H "Host: www.example.com" 'http://172.18.255.200/rewrite/something?foo=bar'
```

Would normally (and previously did) result in the following log output):

```
{
"start_time": "2024-03-13T02:18:21.648Z",
"method": "GET",
"x-envoy-origin-path": "/rewrite/something?foo=bar",
"protocol": "HTTP/1.1",
"response_code": "200",
...
"duration": "1",
"x-envoy-upstream-service-time": "0",
...
}
```

It is now incorrectly outputting the rewritten path instead and losing the original request path:

```
{
"start_time": "2024-03-13T02:23:29.892Z",
"method": "GET",
"x-envoy-origin-path": "/123/something?foo=bar",
"protocol": "HTTP/1.1",
"response_code": "200",
...
"duration": "1",
"x-envoy-upstream-service-time": "-",
...
}
```

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.