envoyproxy / envoyproxy/envoy

Use response_headers_to_add for Envoy-generated error responses

Abierto
#8,944 2 comentarios 2 reacciones 0 asignados Ver en GitHub
enhancement help wanted
Lenguaje dominante
C++
Estrellas
28.9k
Forks
5.6k
Merge medio
1 d 22 h
PR fusionados (30 d)
430

Descripción

On events like a request timeout, Envoy sends a locally generated response (the `sendLocalReply` function). But it doesn't use the `response_headers_to_add` config option. Which could be useful when `response_headers_to_add` has some diagnostic information (e.g. the `%REQ(x-request-id)%` which was added in #8683)

We can fix this by adding `finalizeResponseHeaders` calls before `sendLocalReply` calls, in functions like `onUpstreamAbort`.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.