envoyproxy / envoyproxy/envoy

Use response_headers_to_add for Envoy-generated error responses

Open
#8,944 2 comments 2 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

On events like a request timeout, Envoy sends a locally generated response (the `sendLocalReply` function). But it doesn't use the `response_headers_to_add` config option. Which could be useful when `response_headers_to_add` has some diagnostic information (e.g. the `%REQ(x-request-id)%` which was added in #8683)

We can fix this by adding `finalizeResponseHeaders` calls before `sendLocalReply` calls, in functions like `onUpstreamAbort`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.