envoyproxy / envoyproxy/envoy

HeaderMap: C string to string_view conversion follow ups

Abierto
#6,580 16 comentarios 0 reacciones 1 asignado Reclamado por @dnoe Ver en GitHub
area/security help wanted tech debt
Lenguaje dominante
C++
Estrellas
28.9k
Forks
5.6k
Merge medio
1 d 22 h
PR fusionados (30 d)
430

Descripción

*Description*:

These are various places where we need to follow up to complete removal of C style strings in the header map.

1. `HeaderString::find(const char* str)` can probably be eliminated entirely by converting call sites to use `getStringView().find()`.
1. `StringUtil::atoull` currently requires creation of some temporary `std::string` objects because it expects C strings, and also returns a C style string. Most call sites ignore the return value, so they can be converted to use `absl::SimpleAtoi` or a new `StringUtil` function that takes and returns string views.
1. `UuidUtils::uuidModBy()` should be migrated to take `absl::string_view`
1. `Span::setOperation()` should be migrated to take `absl::string_view`

*Context*:
https://github.com/envoyproxy/envoy/issues/6494
https://github.com/envoyproxy/envoy/pull/6564

**Action item for CVE-2019-9900**

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.