emscripten-core / emscripten-core/emscripten

`test_pthread_print_override_modularize` is failing on macOS after node upgrade to v16

Aperta
#19,683 9 commenti 0 reazioni 0 assegnatari Vedi su GitHub
flaky test
Lingua principale
C++
Stelle
27.6k
Fork
3.6k
Merge medio
1g 14h
PR unite (30g)
125

Descrizione

Ever since we updated the version of node running on the emscripten-releases builder or (https://chromium-review.googlesource.com/c/emscripten-releases/+/4634060) this test has been failing consistenly, but only on macOS and only on the emscripten-releases waterfall (not on the github CI mac bots).

See https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8777589317403048353/+/u/Emscripten_testsuite__other_/stdout

```
FAIL: test_pthread_print_override_modularize (test_other.other)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/s/w/ir/cache/vpython/store/cpython-ste21jq03jlov0apfh16dstb30/contents/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
yield
File "/opt/s/w/ir/cache/vpython/store/cpython-ste21jq03jlov0apfh16dstb30/contents/lib/python3.8/unittest/case.py", line 676, in run
self._callTestMethod(testMethod)
File "/opt/s/w/ir/cache/vpython/store/cpython-ste21jq03jlov0apfh16dstb30/contents/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
method()
File "/opt/s/w/ir/x/w/install/emscripten/test/common.py", line 227, in decorated
f(self, *args, **kwargs)
File "/opt/s/w/ir/x/w/install/emscripten/test/test_other.py", line 5960, in test_pthread_print_override_modularize
self.assertContained('hello, earth!', output)
File "/opt/s/w/ir/x/w/install/emscripten/test/common.py", line 1112, in assertContained
self.fail("Expected to find '%s' in '%s', diff:\n\n%s\n%s" % (
File "/opt/s/w/ir/cache/vpython/store/cpython-ste21jq03jlov0apfh16dstb30/contents/lib/python3.8/unittest/case.py", line 753, in fail
raise self.failureException(msg)
AssertionError: Expected to find 'hello, earth!
' in 'received "loaded" command from terminated worker: 1
received "callHandler" command from terminated worker: 1
', diff:

--- expected
+++ actual
@@ -1 +1,3 @@
-hello, earth!
+received "loaded" command from terminated worker: 1
+received "callHandler" command from terminated worker: 1
+
```

It seems like some kind of race between the thread/program exiting and postMessages being received from the workers.. but I can't seem to reproduce it.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Inizia da test/test_other.py intorno a test_pthread_print_override_modularize alla riga 5960 e dal log collegato di emscripten-releases. Esegui il test sulla configurazione macOS di emscripten-releases ed esamina la gestione di assertContained in test/common.py. È completato quando il test osserva in modo affidabile hello, earth! senza che i messaggi dei worker terminati causino un errore.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
macos, node.js, python
Ambito
ci-cd, testing-qa
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.