emscripten-core / emscripten-core/emscripten

WasmFS: Support non-private mmap

Aperta
#17,801 4 commenti 0 reazioni 1 assegnatario Rivendicata da @kripken Vedi su GitHub
wasmfs
Lingua principale
C++
Stelle
27.6k
Fork
3.6k
Merge medio
1g 16h
PR unite (30g)
117

Descrizione

The `_mmap_js` implementation in syscalls.cpp has a TODO:

```
// TODO: handle non-private mmaps. Those can be optimized in interesting ways
// like avoiding an allocation and a copy as we do below (whereas a
// private mmap is always a copy into a new, private region not shared
// with anything else).
```

It also asserts that the flags contain `MAP_PRIVATE`. We don't need to fully address the optimizations in the TODO yet, but we do need to do better than asserting on `MAP_SHARED`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.