emscripten-core / emscripten-core/emscripten

WasmFS: Support non-private mmap

Open
#17,801 4 comments 0 reactions 1 assignee Claimed by @kripken View on GitHub
wasmfs
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

The `_mmap_js` implementation in syscalls.cpp has a TODO:

```
// TODO: handle non-private mmaps. Those can be optimized in interesting ways
// like avoiding an allocation and a copy as we do below (whereas a
// private mmap is always a copy into a new, private region not shared
// with anything else).
```

It also asserts that the flags contain `MAP_PRIVATE`. We don't need to fully address the optimizations in the TODO yet, but we do need to do better than asserting on `MAP_SHARED`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.