ember-learn / ember-learn/ember-cli-addon-docs

Consider running tests on Windows

Offen
#385 6 Kommentare 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
172
Forks
142
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

The company I work for uses Windows, and we've been using ember-cli-addon-docs to document an internal addon. It is pretty evident that this code-base has not been run on Windows by the developers before. This is fair, but ultimately problematic. Ember-cli-addon-docs is increasingly used by addons across the ecosystem, essentially locking Windows users out of contributing to their documentation unless they are familiar with common issues and can debug/fix them.

We got it to work for us (although there are still rough edges), but I think this is something that will continue to break if Windows support is not part of every PR review. For this reason I propose running the test suite on Windows as well, for example using Appveyor. This is free for open source projects, just like Travis.

Please let me know what you think.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.