ember-learn / ember-learn/ember-cli-addon-docs

Doesn't work with disabled addons

Aperta
#362 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
172
Fork
142
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I've got an addon that's made for testing & development, so I'm using ember-cli's `isEnabled` hook to [disable the addon](https://ember-cli.com/api/classes/Addon.html#method_isEnabled) in production environments.

```js
isEnabled() {
return this.app.env !== "production";
}
```

I just noticed that this returns `false` when `ember deploy production` is run. The deploy completes, but what is shipped to gh-pages is not a complete addon docs app. The `docs` subfolder is missing and the app errors when it tries to request the json file with all modules.

For now I've set `isEnabled` to always return `true`, but I'm wondering if I can somehow have this hook detect if it's running as part of an addon docs deploy?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.