ember-learn / ember-learn/ember-cli-addon-docs
ember 3.7 - babel - nested dependency issue
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 172
- Forks
- 142
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
I recently updated my addon to ember 3.7 (and subsequent update to babel 7) and as a result, am seeing some rather long stack traces in my build logs as a result due to the dependency ember-cli-addon-docs has with ember-keyboard.
Note that this does NOT cause issues with the addon running, or my dummy app running with addon docs...but it makes for some long build logs on our build servers. So I'm posting this more for awareness. Although, that being said, I have not tested specific functionality supported by ember-keyboard, so can't say if it is negatively effected.
From what I can tell, ember-keyboard has a dependency on babel-plugin-transform-object-rest-spread, which is using a deprecated/removed class, and therefore the following stack trace is rendered over and over again when I run ember serve or ember test:
Trace: The node type SpreadProperty has been renamed to SpreadElement
at Object.isSpreadProperty (/Users/.../gitProjects/addons/.../node_modules/@babel/types/lib/validators/generated/index.js:4272:11)
at hasSpread (/Users/.../gitProjects/addons/.../node_modules/babel-plugin-transform-object-rest-spread/lib/index.js:38:13)
at PluginPass.ObjectExpression (/Users/.../gitProjects/addons/.../node_modules/babel-plugin-transform-object-rest-spread/lib/index.js:234:14)
at newFn (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/visitors.js:193:21)
at NodePath._call (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:53:20)
at NodePath.call (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:40:17)
at NodePath.visit (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:88:12)
at TraversalContext.visitQueue (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:118:16)
at TraversalContext.visitMultiple (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:85:17)
at TraversalContext.visit (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:144:19)
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el trace repetido con ember serve o ember test y, a continuación, inspecciona la cadena de dependencias a través de ember-cli-addon-docs, ember-keyboard y babel-plugin-transform-object-rest-spread. El trace apunta a babel-plugin-transform-object-rest-spread/lib/index.js y a los validadores generados por Babel; se consideraría terminado cuando los logs de compilación ya no repitan esta advertencia sin romper el addon ni la aplicación dummy.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- babel, javascript
- Área
- build-system
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100