ember-learn / ember-learn/ember-cli-addon-docs
ember 3.7 - babel - nested dependency issue
- Dominant language
- JavaScript
- Stars
- 172
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
I recently updated my addon to ember 3.7 (and subsequent update to babel 7) and as a result, am seeing some rather long stack traces in my build logs as a result due to the dependency `ember-cli-addon-docs` has with `ember-keyboard`.
Note that this does NOT cause issues with the addon running, or my dummy app running with addon docs...but it makes for some long build logs on our build servers. So I'm posting this more for awareness. Although, that being said, I have not tested specific functionality supported by `ember-keyboard`, so can't say if it is negatively effected.
From what I can tell, `ember-keyboard` has a dependency on `babel-plugin-transform-object-rest-spread`, which is using a deprecated/removed class, and therefore the following stack trace is rendered over and over again when I run `ember serve` or `ember test`:
```
Trace: The node type SpreadProperty has been renamed to SpreadElement
at Object.isSpreadProperty (/Users/.../gitProjects/addons/.../node_modules/@babel/types/lib/validators/generated/index.js:4272:11)
at hasSpread (/Users/.../gitProjects/addons/.../node_modules/babel-plugin-transform-object-rest-spread/lib/index.js:38:13)
at PluginPass.ObjectExpression (/Users/.../gitProjects/addons/.../node_modules/babel-plugin-transform-object-rest-spread/lib/index.js:234:14)
at newFn (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/visitors.js:193:21)
at NodePath._call (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:53:20)
at NodePath.call (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:40:17)
at NodePath.visit (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/path/context.js:88:12)
at TraversalContext.visitQueue (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:118:16)
at TraversalContext.visitMultiple (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:85:17)
at TraversalContext.visit (/Users/.../gitProjects/addons/.../node_modules/@babel/traverse/lib/context.js:144:19)
```
Contributor guide
Assessment
This issue has not been assessed yet.