ember-learn / ember-learn/ember-cli-addon-docs

data-test on docs-header/link breaks with ember-test-selectors@^2.0.0

Open
#281 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
172
Forks
142
PR merge metrics
No merged PRs in 30d

Description

ember-test-selectors@^2.0.0 breaks on this line

https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/components/docs-header/template.hbs#L26

due to binding on a tagless component

https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/components/docs-header/link/component.js#L8

Contributor guide

Open the contributing guide

Research direction

Start by reading addon/components/docs-header/template.hbs at line 26 and addon/components/docs-header/link/component.js at line 8 to understand the data-test binding and tagless component. Reproduce the failure with ember-test-selectors@^2.0.0, then verify that the docs-header link renders its data-test selector without the compatibility error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.