ember-cli / ember-cli/loader.js
Support For define.amd
- Dominant language
- JavaScript
- Stars
- 79
- Forks
- 69
- PR merge metrics
- No merged PRs in 30d
Description
Trying to use rollup for a refactor of Backburner with @krisselden and others. I noticed that rollup has AMD check looks for `define && define.amd`. Loader.js explicitly opts out of this with `define.petals`, wondering if people would be opposed to just setting `define.amd` to `true`. It's not spec compliant, however loader.js is already not spec compliant in this regard.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in Loader.js and inspect how the loader currently exposes define.petals and opts out of the define.amd check. Review the issue discussion before changing compatibility behavior, then verify that Rollup recognizes the loader without breaking its existing AMD behavior. Done means the intended define.amd support is implemented and its compatibility trade-off is covered by the project’s available checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100