ember-cli / ember-cli/ember-cli-version-checker

`NPMDependencyVersionChecker` `_jsonPath` is null if `basedir` = `/`

Ouverte
#275 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
24
Forks
20
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

While working on a Docker file I encountered a problem where a version check performed by `ember-cli-version-checker` would fail when running in Docker. The error occurred because the Ember app source files were stored at the root of the drive.

In `/src/npm-dependency-version-checker.js` the following code is used for the `_jsonPath` property:

```
this._jsonPath = resolvePackage(this.name, basedir);
```

If `basedir` is `/` then `this._jsonPath` ends up being `null`. So this Docker file would lead to an error:

```
FROM node:14.16.0

# Copy the main application.
COPY . ./

...
ember build
```

This Docker file works correctly though:

```
FROM node:14.16.0

# Copy the main application.
COPY . ./my-ember-app
WORKDIR my-ember-app

...
ember build
```

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.