ember-cli / ember-cli/ember-cli-version-checker

`NPMDependencyVersionChecker` `_jsonPath` is null if `basedir` = `/`

Open
#275 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
24
Forks
20
PR merge metrics
No merged PRs in 30d

Description

While working on a Docker file I encountered a problem where a version check performed by `ember-cli-version-checker` would fail when running in Docker. The error occurred because the Ember app source files were stored at the root of the drive.

In `/src/npm-dependency-version-checker.js` the following code is used for the `_jsonPath` property:

```
this._jsonPath = resolvePackage(this.name, basedir);
```

If `basedir` is `/` then `this._jsonPath` ends up being `null`. So this Docker file would lead to an error:

```
FROM node:14.16.0

# Copy the main application.
COPY . ./

...
ember build
```

This Docker file works correctly though:

```
FROM node:14.16.0

# Copy the main application.
COPY . ./my-ember-app
WORKDIR my-ember-app

...
ember build
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.