ember-cli / ember-cli/ember-cli-update

Formatting applied by `ember-cli-update --run-codemods` disagrees with `yarn lint:fix`

Open
#1,263 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
279
Forks
44
PR merge metrics
No merged PRs in 30d

Description

I'm working on updating an app from `4.4` up to `6.4` by jumping from LTS release to LTS release (4.4, 4.4, 4.12, 5.4, etc...).

For each new LTS release when I run `ember-cli-update --run-codemods` it makes purely formatting changes to nearly every test file in the project. And then if I run `yarn lint:fix` it undoes some of those changes and/or makes a different set of changes.

It would be nice if those two things agreed about the proper way to format stuff.

Apologies if this isn't the right place to raise this issue. If that's the case please point me to the proper place.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the reported upgrade path from Ember CLI 4.4 through the listed LTS releases, running `ember-cli-update --run-codemods` and then `yarn lint:fix` on the test files. Compare the formatting changes from both commands; done means the codemods and lint fixer agree on formatting rather than undoing or adding changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.