ember-cli / ember-cli/ember-cli-update

Can't ran any of the codemods

Open
#1,105 8 comments 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
279
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Updating app to the latest Ember version (3.24.0) succeeded but running any of the codemods after that always fail:

Output from command with debug flag:

```
$ DEBUG=ember-cli-update,boilerplate-update,git-diff-apply ember update --run-codemods
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Running as an Ember addon is deprecated. Please run as a global install instead.
? Which blueprint would you like to run codemods for? ember-cli
? These codemods apply to your project. Select which ones to run. es5-getter-ember-codemod
Running codemod es5-getter-ember-codemod
Running command 1 of 1
boilerplate-update npx github:rondale-sc/es5-getter-ember-codemod es5-getter-ember-codemod app/**/*.js tests/*.js tests/!(dummy)/**/*.js tests/dummy/app/**/*.js +0ms
boilerplate-update npx github:rondale-sc/es5-getter-ember-codemod es5-getter-ember-codemod app/**/*.js tests/*.js tests/!(dummy)/**/*.js tests/dummy/app/**/*.js {
preferLocal: true,
stdio: [ 'pipe', 'pipe', 'inherit' ],
cwd: '/home/lucas/Workspace/src/github.com/lowski/fapiao'
} +1ms
npm ERR! cb.apply is not a function

npm ERR! A complete log of this run can be found in:
npm ERR! /home/lucas/.npm/_logs/2021-01-24T14_12_32_031Z-debug.log
Install for [ 'github:rondale-sc/es5-getter-ember-codemod' ] failed with code 1
Error running command github:rondale-sc/es5-getter-ember-codemod es5-getter-ember-codemod app/**/*.js tests/*.js tests/!(dummy)/**/*.js tests/dummy/app/**/*.js
Error: Command failed with exit code 1: npx github:rondale-sc/es5-getter-ember-codemod es5-getter-ember-codemod app/**/*.js tests/*.js tests/!(dummy)/**/*.js tests/dummy/app/**/*.js
at makeError (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/boilerplate-update/node_modules/execa/lib/error.js:59:11)
at handlePromise (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/boilerplate-update/node_modules/execa/index.js:114:26)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Object.runCodemod (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/boilerplate-update/src/run-codemod.js:21:9)
at async runCodemods (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/boilerplate-update/src/run-codemods.js:7:5)
at async promptAndRunCodemods (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/boilerplate-update/src/prompt-and-run-codemods.js:20:3)
at async codemods (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/ember-cli-update/src/codemods.js:80:10)
at async Class.run (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/ember-cli-update/src/command.js:99:16)
at async /home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/ember-cli/lib/cli/cli.js:204:32
at async CLI.run (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/ember-cli/lib/cli/cli.js:251:14)
at async module.exports (/home/lucas/Workspace/src/github.com/lowski/fapiao/node_modules/ember-cli/lib/cli/index.js:145:12)
boilerplate-update git add -A { cwd: '/home/lucas/Workspace/src/github.com/lowski/fapiao' } +1s
Cannot read property 'resolveConflictsProcess' of undefined

Stack Trace and Error Report: /tmp/error.dump.a7f40e3ebdb5556e6ac210592d1140eb.log
```

After quick research it looks like it might be an issue with https://github.com/isaacs/node-graceful-fs/issues/192 but I'm not sure how to fix it.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the reported `ember update --run-codemods` command and inspect the stack-trace entry points in `boilerplate-update/src/run-codemod.js`, `boilerplate-update/src/run-codemods.js`, and `ember-cli-update/src/codemods.js`. Check the reported npm and node-graceful-fs failure before changing behavior. Done means the codemod completes without the npm error or the subsequent `resolveConflictsProcess` failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.