ember-cli / ember-cli/ember-cli-update

CI Failures from forks

Open
#1,085 0 comments 0 reactions 0 assignees View on GitHub
internal
Dominant language
JavaScript
Stars
279
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Folks sending in a PR from their local forks will always cause a failure of the `ember-cli-update` CI job. This is due to the usage of `${{ secrets.GitHubToken }}` here:

https://github.com/ember-cli/ember-cli-update/blob/fc221be115e87049427d33f17cf11879637ea9c7/.github/workflows/ci.yml#L72-L73

Pull requests from forks will not have access to any `${{ secrets.* }}` content (for somewhat clear security reasons).

See [documentation here](https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets#using-encrypted-secrets-in-a-workflow), which starts out with:

> With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect .github/workflows/ci.yml at lines 72-73 and review the GitHub Actions fork and secrets documentation linked in the issue. Verify the workflow behavior for pull requests from local forks; done means the ember-cli-update CI job no longer fails solely because the fork cannot access the referenced secret.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.