ember-cli / ember-cli/ember-cli-update

Blueprint isn't run if it doesn't match the package name

Aperta
#1,078 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
279
Fork
44
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hello,

Let me know if this is a user error or my idea of how this should work is incorrect.

### What I'm trying to achieve
I'm testing out using partial blueprints to update a set of `addons` that bootstrap the same. For example, let's say I have 5 addons that have the same base .eslintrc, .gitignore, and testing configurations. These configs were generated by a blueprint from another addon say `base-addon-project` from `@spham/base-blueprints`. I want to change just that `base-addon-project` blueprint, bump the version for `@spham/base-blueprints` and use `ember-cli-update` to update those 5 addons.

Example `ember-cli-update.json`

```json
{
"schemaVersion": "1.0.0",
"packages": [
{
"name": "ember-cli",
"version": "3.21.2",
"blueprints": [
{
"name": "addon",
"outputRepo": "https://github.com/ember-cli/ember-addon-output",
"codemodsSource": "ember-addon-codemods-manifest@1",
"isBaseBlueprint": true,
"options": [
"--welcome",
"--yarn"
]
}
]
},
{
"name": "@stpham/base-blueprints",
"version": "0.0.3",
"blueprints": [
{
"name": "base-addon-project"
}
]
}
]
}
```

### What I'm experiencing
So I make changes to the blueprint and publish a new version of `@stpham/base-blueprints` (I'm using a private registry and I believe I configured my global npm configs correctly). When I run `ember-cli-update.json`, it recognizes that there is a new version and I select `base-addon-project` to be updated, `ember-cli-update` does its thing but the resulting diff doesn't contain the diff I expect. My changes are to the blueprint is adding new files

When I make another addon and have the blueprint match the package name, it seems to run the blueprint. For example `@stpham/base-addon-blueprint` blueprint for `@stpham/base-addon-blueprint` addon.

Am I doing something wrong or is my expectations incorrect?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.