ember-cli / ember-cli/ember-cli-test-loader

What should happen when failure to load a module?

Aperta
#39 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
10
Fork
20
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Currently, when requiring a test file, if an error gets throw, the error is logged by `console.error()` and the test-loader will continue to require the next test file.
See https://github.com/ember-cli/ember-cli-test-loader/blob/master/addon-test-support/index.js#L71

This effectively ignores all the tests that are part of the test file that did not get required, which would cause unexpected missing test coverage.

Was interested in knowing what is the rational in the choice of the current implementation.
@rwjblue would you have some context on this?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.