ember-cli / ember-cli/ember-cli-htmlbars

TemplateFactory type incompatible with setComponentTemplate type from @types/ember__component

Aperta
#787 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
77
Fork
65
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

With ember-cli-htmlbars 6.3.0 and latest version 4.0.22 of `@types/ember__component`, for this type of code...

```
import { hbs } from 'ember-cli-htmlbars';
import { setComponentTemplate } from '@ember/component';

export const Button = setComponentTemplate(
hbs`
{{yield}}`,
templateOnly(),
);
```

I am getting this type error:

```
Argument of type 'import("/[...]/node_modules/ember-cli-htmlbars/lib/index").TemplateFactory' is not assignable to parameter of type 'TemplateFactory'.
Property '__htmlbars_inline_precompile_template_factory' is missing in type 'import("/[...]/node_modules/ember-cli-htmlbars/lib/index").TemplateFactory' but required in type 'TemplateFactory'.ts(2345)
index.d.ts(14, 5): '__htmlbars_inline_precompile_template_factory' is declared here.
```

`@types/ember__component` is still defining `TemplateFactory` like this:

```
interface TemplateFactory {
__htmlbars_inline_precompile_template_factory: any;
}
```

But https://github.com/ember-cli/ember-cli-htmlbars/pull/764 removed that `__htmlbars_inline_precompile_template_factory` property (used as a way of type branding I guess?), so I am indeed wondering how this is supposed to work now? Maybe just working with Ember's native types?

/cc @chriskrycho

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.