ember-cli / ember-cli/ember-cli-htmlbars

Code coverage off by 2 lines in components with co-located template

Offen
#779 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
77
Forks
65
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

In components with a co-located template, the plugin adds `import { hbs }` and `const __COLOCATED_TEMPLATE__ = ...` to the source file, and that is affecting the code coverage. Not only does this affect the percentage itself, as `const __COLOCATED_TEMPLATE__ = ...` is seen as a line that is covered without it being part of the source code, it also makes it very difficult to look at a coverage report as the lines are off by 2 (see screenshot)

In https://github.com/ember-cli/ember-cli-htmlbars/pull/558 and https://github.com/ember-cli/ember-cli-htmlbars/pull/763, something similar is addressed, but then just for source maps which appeared to be resolved without the fixes. However, for the code coverage this is still relevant, and placing the lines at the end would at least solve the off-by-2 issues (would have been fun if it was the typical off-by-1 error :smile:)

![image](https://github.com/ember-cli/ember-cli-htmlbars/assets/5949434/ed94281c-e26a-46ef-8bfd-ef2aba605a24)

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.