ember-cli / ember-cli/ember-cli-app-version

App version in Ember console debug statements

Aperta
#13 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
55
Fork
42
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Just started using this in our app, so thanks :smile:

Since the addon defines an initializer that registers the app as an ember library, I was surprised to see that it wasn't listed in the normal [library version debug output](https://github.com/emberjs/ember.js/blob/v1.11.0-beta.4/packages/ember-application/lib/system/application.js#L1106-L1126). After a little digging it appears that initializers run after [that method is called](https://github.com/emberjs/ember.js/blob/v1.11.0-beta.4/packages/ember-application/lib/system/application.js#L282), so the app version isn't in the list when it's printed. Not a big deal, but I've definitely found it handy to find the version in the console without opening the ember inspector and clicking the info tab (I used to call `Ember.libraries.register` in `app/app.js` directly).

I would have opened a PR, but I can't figure out how to use addon hooks to run code before `Ember.Application#init` is called. The only thing I could think of was to add an inline script using the `contentFor` hook, but that ends up violating CSP. Do you have any idea how to do this?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.