element-hq / element-hq/element-x-android

[Architecture] Allow Activity to be injected through the dagger graph.

Abierto
#558 0 comentarios 0 reacciones 0 asignados Ver en GitHub
S-Tolerable T-Task
Lenguaje dominante
Kotlin
Estrellas
2.4k
Forks
624
Merge medio
1 d 14 h
PR fusionados (30 d)
149

Descripción

We might need to inject an activity context in some of our classes used by Presenter or others.
We can trick it by using the `LocalContext.current` but it's a hack.
We should probably create a `Component` owned by `MainActivity` so we can inject it in subcomponents.
It could require to create new subcomponents for Session and Room, as the existant ones can be used outside the context of an activity (like from notification).

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.