electerious / electerious/basicGrid

Larger size column offsets can't be zero when a smaller size offset is greater than zero

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
SCSS
Stars
57
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Columns with `small-offset-x` and `large-offset-0` or `medium-offset-0` don't seem to work. The zeroed out offsets (if set to greater than zero it functions as expected) just inherit the value of the `small-offset-x` for the larger breakpoints. This seems to be because of the way the `margin-left` value is calculated as a percentage.

~~Adding this as an override for those two classes specifically seems to fix the issue:~~ Never mind this seems to override the small offset at the small size. :(
```css
.large-offset-0, .medium-offset-0 {
margin-left: 0 !important;
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the grid styles for small-offset-x, large-offset-0, and medium-offset-0, then inspect how their margin-left percentage is calculated across breakpoints. Reproduce a small offset with a zero large or medium offset; done means the larger breakpoint uses zero without changing the small breakpoint offset.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, scss
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.