electerious / electerious/basicGrid

hide-on & show-on seem to break anything that isn't set as display block

Open
#11 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
SCSS
Stars
57
Forks
7
PR merge metrics
No merged PRs in 30d

Description

When using `hide-on` and `show-on` to change the visibility of an element set to `display: flex;` it seems to override the existing display mode and set it to block which is undesired. Setting `show-on` to `display: inherit` seems to have fixed this for me but I don't feel confident enough in my CSS skills to just go and submit a PR for this issue!

Would appreciate it if somebody a little more knowledgeable wouldn't mind testing this ;P

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with an element using `display: flex` and the `hide-on` or `show-on` behavior described in the report. Inspect how those SCSS utilities set display values; done means visibility changes no longer replace an element's existing non-block display mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.