elastic / elastic/apm-agent-python

metrics.base_metrics.Counter API

Aperta
#490 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
agent-python
Lingua principale
Python
Stelle
431
Fork
239
Merge medio
5g 10h
PR unite (30g)
7

Descrizione

Is Counter meant to guarantee monotonically increasing values? It doesn't at the moment, since there's both a `dec` method and an `inc` method that accepts negative values.

What's the reason behind not providing a direct value setter? Even if we require the value to be monotonically increasing, you could for example check the current value and raise an exception if the new value is less. If there were a setter, then the `GarbageMetrics.collect` method in https://github.com/elastic/apm-agent-python/pull/481 could be simplified.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.