elastic / elastic/apm-agent-java

Add support for javalin 5, currently the instrumentation crashes

Abierto
#3,908 0 comentarios 0 reacciones 1 asignado Reclamado por @LikeTheSalad Ver en GitHub
agent-java
Lenguaje dominante
Java
Estrellas
594
Forks
338
Merge medio
1 d 13 h
PR fusionados (30 d)
25

Descripción

Per [report in the discussion forums](https://discuss.elastic.co/t/error-in-apm-java-agent-when-using-latest-javalin-versions/371702) our instrumentation currently doesn't support javalin 5:
```
java.lang.IncompatibleClassChangeError: Found interface io.javalin.http.Context, but class was expected
at co.elastic.apm.agent.javalin.JavalinInstrumentation$HandlerAdapterAdvice.setSpanAndTransactionName(JavalinInstrumentation.java:177) ~[elastic-apm-agent.jar:1.52.1]
at xx.xxxxx.xxxxxx.xxxxxxx.xxxxx.TestFilter.handle(TestFilter.java:40) ~[test-1.0.0-SNAPSHOT.jar:?]
at io.javalin.router.Endpoint.handle(Endpoint.kt:52) ~[javalin-6.1.3.jar:6.1.3]
at io.javalin.router.ParsedEndpoint.handle(ParsedEndpoint.kt:15) ~[javalin-6.1.3.jar:6.1.3]
```

We should
* add support for javalin 5
* Ensure that version 3.13.8, latest 3.x, latest 4.x and overall latest (currently 5.x) still work via tests (see [this](https://github.com/elastic/apm-agent-java/blob/main/apm-agent-plugins/apm-apache-httpclient/apm-apache-httpclient4-plugin/src/test/java/co/elastic/apm/agent/httpclient/v4/LegacyApacheHttpClientVersionIT.java) as an example)
* Add javalin to the dependabot config to ensure we don't miss future updates

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.