eclipsesource / eclipsesource/jsonforms
Support Start-/EndAdornments for Input fields
- Lenguaje dominante
- TypeScript
- Estrellas
- 2.7k
- Forks
- 423
- Merge medio
- 17 d 8 h
- PR fusionados (30 d)
- 1
Descripción
### Is your feature request related to a problem? Please describe.
When inputting number/integers it is often required to indicate what unit needs to be kept in mind.
It is currently not possible to use inputAdornments when using jsonForms
### Describe the solution you'd like
I would like to add support to all inputFields to have a start or end adornment.
At least for the material renderers in react, this shouldn't be to hard because of the out-of-the-box support or adornments in the MUI React library (https://mui.com/material-ui/api/input-adornment/#main-content)
### Describe alternatives you've considered
I tried to adapt the existing controls, to add an `startAdornment` and/or `endAdornment` prop to the MUI `Input`-component.
This is however currently not possible because:
- `MuiInputInteger` and `MuiInputNumber` don't forward props to the `Input` component (https://github.com/eclipsesource/jsonforms/blob/master/packages/material/src/mui-controls/MuiInputInteger.tsx)
- the generic `MaterialInputControl` (adding all of the surrounding components, like label, description, helperTexts, ...) is not exported from the library, so we current can't redefine an additional `MaterialIntegerControl` with support for the start- endAdornments
### Framework
React
### RendererSet
Material
### Additional context
_No response_
Guía de contribución
Línea de trabajo
Empieza leyendo packages/material/src/mui-controls/MuiInputInteger.tsx y la implementación correspondiente de MuiInputNumber; después, sigue cómo MaterialInputControl ensambla las etiquetas, las descripciones y el texto de ayuda. Revisa las pruebas o ejemplos existentes del renderizador de Material antes de hacer cambios. Se considera terminado cuando los campos de entrada de Material React admitan adornments iniciales y finales configurables sin perder su comportamiento de control existente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- react, typescript
- Área
- frontend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100