eclipsesource / eclipsesource/jsonforms

Support Start-/EndAdornments for Input fields

Open
#2,018 1 comment 1 reaction 0 assignees View on GitHub
feature material react
Dominant language
TypeScript
Stars
2.7k
Forks
424
Avg merge
17d 8h
Merged PRs (30d)
1

Description

### Is your feature request related to a problem? Please describe.

When inputting number/integers it is often required to indicate what unit needs to be kept in mind.
It is currently not possible to use inputAdornments when using jsonForms

### Describe the solution you'd like

I would like to add support to all inputFields to have a start or end adornment.
At least for the material renderers in react, this shouldn't be to hard because of the out-of-the-box support or adornments in the MUI React library (https://mui.com/material-ui/api/input-adornment/#main-content)

### Describe alternatives you've considered

I tried to adapt the existing controls, to add an `startAdornment` and/or `endAdornment` prop to the MUI `Input`-component.

This is however currently not possible because:

- `MuiInputInteger` and `MuiInputNumber` don't forward props to the `Input` component (https://github.com/eclipsesource/jsonforms/blob/master/packages/material/src/mui-controls/MuiInputInteger.tsx)
- the generic `MaterialInputControl` (adding all of the surrounding components, like label, description, helperTexts, ...) is not exported from the library, so we current can't redefine an additional `MaterialIntegerControl` with support for the start- endAdornments

### Framework

React

### RendererSet

Material

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.