eclipse-score / eclipse-score/bazel_cpp_toolchains

Missing sysroot flags for assembler actions in 1.0.3 for autosd10 build

Offen
#141 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Starlark
Sterne
2
Forks
11
Ø Merge
2 T. 8 Std.
Gemergte PRs (30 T.)
10

Beschreibung

### Description

In version 1.0.3, the sysroot configuration seems to be missing for assembler actions. This causes the compiler to fall back to the host system paths (e.g., /usr/include) when compiling .S assembly files, breaking build hermeticity and throwing absolute path inclusion(s) found in rule errors in Bazel.

Note that the same build worked in 0.5.4

### Analysis results

_No response_

### Solution

_No response_

### Error Occurrence Rate

None

### How to reproduce

- Use score_bazel_cpp_toolchains version 1.0.3.
- use autosd toolchain:

> gcc = use_extension("@score_bazel_cpp_toolchains//extensions:gcc.bzl", "gcc")
> gcc.toolchain(
> name = "score_cc_autosd10_x86_64",
> runtime_ecosystem = "autosd10",
> target_cpu = "x86_64",
> target_os = "linux",
> use_default_package = True,
> )

- Try to compile a project that includes pure assembly files with a C preprocessor (e.g., BoringSSL with its .S files).
- The build will fail during the assembly step with an error like:

`Compiling crypto/hrss/asm/poly_rq_mul.S failed: absolute path inclusion(s) found in rule '@@boringssl+//:crypto':
the source file 'crypto/hrss/asm/poly_rq_mul.S' includes the following non-builtin files with absolute paths:
'/usr/include/stdc-predef.h'
`

### Supporting Information

_No response_

### Classification

Major

### First Affected Release

1.0

### Last Affected Release

1.0

### Expected Fixed Release

before release (main)

### Category

- [ ] Safety Relevant
- [ ] Security Relevant

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start with the gcc extension at @score_bazel_cpp_toolchains//extensions:gcc.bzl and reproduce the autosd10 configuration from the issue using a project with BoringSSL .S files. Check the assembler action's sysroot handling; done means the assembly step no longer falls back to /usr/include or reports absolute path inclusions.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
cpp
Bereich
build-system
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
58/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.