eclipse-platform / eclipse-platform/eclipse.platform

[memory] JavaBuilder.oldState leaks into Workspace.tree

Open
#910 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
165
Forks
174
Avg merge
2d 8h
Merged PRs (30d)
22

Description

In the heapdump of https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1612 most memory was hold by org.eclipse.core.internal.resources.Workspace.tree.
VisualVM:
![image](https://github.com/eclipse-platform/eclipse.platform/assets/51790620/3f4dc0c2-af0e-497a-823c-9992e715b65b)

![image](https://github.com/eclipse-platform/eclipse.platform/assets/51790620/04b8f220-9dc7-42a1-b72f-b646c68a0f74)
JDKMC:
![image](https://github.com/eclipse-platform/eclipse.platform/assets/51790620/e099ae0c-18a1-44f8-ba9e-08155f5984bc)

Workspace.tree is meant to store the state of the Workspace. It does so by storing the history of changes (DeltaDataTree) to the workspace. Interestingly the workspace also stores all IncrementalBuilders which again contain references to the old trees.
I.e the Workspace stores a history of things that contain their history.
That org.eclipse.core.internal.events.InternalBuilder.oldState sounds like a leak - or say - something that unintentionally stores more memory then intended.

I have however no idea how to reduce that since an IncrementalBuilders needs to know the oldState to calculate increments. Just that the old state is stored again as a history feels odd.

Contributor guide

Open the contributing guide

Research direction

Use the linked heap-dump analysis as the starting point, then read Workspace.tree, DeltaDataTree, and InternalBuilder.oldState, including JavaBuilder's oldState references. Trace why builder state remains retained and identify the intended lifecycle; the issue is done when a reviewed approach reduces unintended retention and includes evidence that incremental builds still work correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
performance, tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.