eclipse-platform / eclipse-platform/eclipse.platform

File corruption when moving file accross projects that have different charsets

Aperta
#581 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
165
Fork
174
Merge medio
2g 8h
PR unite (30g)
22

Descrizione

### Current Behaviour
When moving a file across two projects with different charsets, a file with no specified charset gets corrupted.

### Reproducing*
```
Version: 2023-09 (4.29)
Build id: I20230711-0440
```
1) Create two projects
2) Set the default encodings of the projects, set them to different charsets
3) Create a file in one project
4) Move the file from one project to the other
5) See the File's implied charset not match the old implied charset

### Expected Behaviour
I propose this behaviour:
- When moving a file without explicitly set charset into a project where the new implicit charset would conflict with the current implicit charset, the old charset is set to an explicit charset in the file
- When moving a file with explicitly set charset into a project which has the same default charset as the explicitly set charset, unset the charset preference

--
This issue mirrors [this](https://bugs.eclipse.org/bugs/show_bug.cgi?id=380114) issue.
What do you think is the expected behaviour here? Do you agree with my proposal?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.