duckdb / duckdb/duckdb-python

Arrow scan: a NULL row passes a pushed-down `<=` filter against a NaN constant

Aperta
#615 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
needs triage
Lingua principale
Python
Stelle
187
Fork
112
Merge medio
13h 29m
PR unite (30g)
17

Descrizione

### What happens?

When a `WHERE b <= 'nan'::DOUBLE` filter is pushed into an Arrow scan, the scan returns rows where b is NULL.

The same predicate over same rows copied to a native table (correctly) excludes the null rows.

This *should* exclude the nulls (`NULL <= x` is false): The bug appears to be in the arrow filter_pushdown: disabling the optimizer/pushdowns returns the correct results.

### To Reproduce

```py
import duckdb
import pyarrow as pa

with duckdb.connect() as con:

print(f"duckdb {duckdb.__version__}, pyarrow {pa.__version__}", "source id:", con.execute("SELECT source_id FROM pragma_version()").fetchone()[0])

arrow_table = pa.table({"b": pa.array([1.0, float("nan"), None])})
con.register("arrow_t", arrow_table)

result_native = con.execute("create table native_t as select * from arrow_t;select b from native_t where b <= 'nan'::DOUBLE").fetchall()

result = con.execute("select b from arrow_t where b <= 'nan'::DOUBLE").fetchall()

con.execute("PRAGMA disable_optimizer;")
result_no_optimizer = con.execute("select b from arrow_t where b <= 'nan'::DOUBLE").fetchall()

print(f"{result_native=}")
print(f"{result=}")
print(f"{result_no_optimizer=}")
```

## Result: Note that "result" differs from others
>
> duckdb 1.6.0.dev379, pyarrow 25.0.1 source id: a00803f768
> result_native=[(1.0,), (nan,)]
> result=[(1.0,), (nan,), (None,)]
> result_no_optimizer=[(1.0,), (nan,)]

### OS:

Windows & Ubuntu WSL

### DuckDB Package Version:

1.5.5 and 1.6.0.dev379

### Python Version:

3.14

### Full Name:

Paul T

### Affiliation:

Iqmo

### What is the latest build you tested with? If possible, we recommend testing with the latest nightly build.

I have tested with a nightly build

### Did you include all relevant data sets for reproducing the issue?

Yes

### Did you include all code required to reproduce the issue?

- [x] Yes, I have

### Did you include all relevant configuration to reproduce the issue?

- [x] Yes, I have

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the Python reproduction using the registered PyArrow table and compare the Arrow scan with the native-table and optimizer-disabled results. Trace the Arrow filter pushdown for `b <= 'nan'::DOUBLE`; done means the pushed-down query excludes the NULL row like the other results, with a regression test covering the case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
databases
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
68/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.