drawshield / drawshield/Drawshield-Code

Charge Orientation re-work

Aperta
#69 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement Medium
Lingua principale
PHP
Stelle
60
Fork
21
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Implement the following:

As part of their metadata, charges have an "aspect", with values of "landscape" or "portrait". This can be specified explicitly in extradata.inc, or be calculated.
$aspect = $height > $width ? "portrait" : "landscape";

Charges also have a "facing" direction, with values "left", "right", "up", "down" or "none". This can be specified explicitly, or have the default value "left".

At least some of the combinations are to be implemented as shown below:

![orientation](https://user-images.githubusercontent.com/3171760/79645460-82ab3000-81a7-11ea-9ce9-94b73160df4f.png)

These metadata items will also be used to determine whether (and how) charges are oriented in line with any ordinaries that they are placed "on".

More details to follow.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.