drawshield / drawshield/Drawshield-Code

Charge Orientation re-work

Open
#69 1 comment 0 reactions 0 assignees View on GitHub
enhancement Medium
Dominant language
PHP
Stars
60
Forks
21
PR merge metrics
No merged PRs in 30d

Description

Implement the following:

As part of their metadata, charges have an "aspect", with values of "landscape" or "portrait". This can be specified explicitly in extradata.inc, or be calculated.
$aspect = $height > $width ? "portrait" : "landscape";

Charges also have a "facing" direction, with values "left", "right", "up", "down" or "none". This can be specified explicitly, or have the default value "left".

At least some of the combinations are to be implemented as shown below:

![orientation](https://user-images.githubusercontent.com/3171760/79645460-82ab3000-81a7-11ea-9ce9-94b73160df4f.png)

These metadata items will also be used to determine whether (and how) charges are oriented in line with any ordinaries that they are placed "on".

More details to follow.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.