drawshield / drawshield/Drawshield-Code

Turn treatments to match bend on flags

Open
#278 0 comments 0 reactions 0 assignees View on GitHub
Medium No Fix Likely
Dominant language
PHP
Stars
60
Forks
21
PR merge metrics
No merged PRs in 30d

Description

On a shield the bend is always 45 so we turn (some) treatments to match.

O a flag bends are at an abitrary angle depending on the proportions. We should calculate the appropriate angle and turn the same set of treatments accordingly.

![shield(1)](https://user-images.githubusercontent.com/3171760/138360722-33f0a07b-e080-4527-90ca-8f1ad22cbca0.png)

(For the same reason we don't currently support charges "on a bend" in flags as we don't have the angle)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the existing treatment rotation for shields and the code that determines bend geometry for flags. Calculate the flag bend angle from its proportions and apply the same treatment rotation behavior; done when treatments match the bend on flags while shield behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.