Consider updating Math.Clamp to not throw when min is greater than max
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start with the Math.Clamp APIs named in the issue and review the linked discussion for the proposed semantics. Compare the existing behavior with the vector APIs mentioned, then identify the relevant implementation and tests. Done means the behavior for correctly ordered and swapped min/max values is explicitly decided and covered consistently.
Written by the indexing model from the issue text.
Description
As noted by @tannergooding:
It's pretty typical for Clamp APIs to follow a well-specified order for mismatched min/max, as it's far more efficient and is useful for a number of scenarios. -- We end up doing just this for the vector APIs and it correspondingly can bleed into other scenarios, like Tensors
The typical behavior is Min(Max(value, min), max) which matches what hardware typically does for such instructions, what HLSL and GLSL do, etc. -- Effectively this returns max if min/max are incorrectly ordered.
Default behavior (min/max are correctly ordered)
| value | min | max | result |
|---|---|---|---|
| 1 | 2 | 3 | 2 |
| 2 | 1 | 3 | 2 |
| 3 | 1 | 2 | 2 |
Swapped behavior (Min(Max(value, min), max))
| value | min | max | result |
|---|---|---|---|
| 1 | 3 | 2 | 2 |
| 2 | 3 | 1 | 1 |
| 3 | 2 | 1 | 1 |
Swapped behavior (Max(Min(value, max), min))
| value | min | max | result |
|---|---|---|---|
| 1 | 3 | 2 | 3 |
| 2 | 3 | 1 | 3 |
| 3 | 2 | 1 | 2 |
Originally posted by @tannergooding in https://github.com/dotnet/runtime/pull/118824#discussion_r2282953148
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSResourceGet#2056 ·