ILC race condition can result in duplicate warnings

Open
#119,155 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
compilers

Research direction

Start by tracing CreateValueFromKey in LockFreeReaderHashtable and the IL2041 warning path described in the issue. Reproduce the reported testcase under parallel hashtable population, then add or update coverage so duplicate warnings cannot be emitted and the existing warning behavior remains correct.

Written by the indexing model from the issue text.

Description

area-NativeAOT-coreclr

While debugging a testcase I saw that sometimes duplicate IL2041 warnings were emitted. I believe this is because they are logged inside of CreateValueFromKey of a LockFreeReaderHashtable. As far as I understand, CreateValueFromKey may be called in parallel if the hashtable is being populated from multiple readers, so should not have side-effects.

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.