Reenable MSBuild Terminal Logger

Open
#119,012 19 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell, shell

Research direction

Start with the terminal logger settings in build.sh, build.ps1, and Directory.Build.rsp, then review the reenableTerminalLogger branch and the linked MSBuild change. Try the proposed configuration with detailed verbosity and gather feedback on native build output, test failure results, and project logging before deciding whether to reenable it for 11.0.

Written by the indexing model from the issue text.

Description

area-Infrastructure

We turn off the terminal logger in a few places - the outer build scripts (build.sh/build.ps1) and in Directory.Build.rsp.

Before, we did this because the terminal logger wasn't showing output from native build, nor was it showing test failure results.

The test results issue seems to be fixed, and the native build output can be enabled if we pass in /v:detailed due to https://github.com/dotnet/msbuild/pull/9810.

The largest difference is that logging for a project is not emitted until that project completes, however progress is still shown for the project.

I'd like for a couple folks to try it out and see what they think, if we're happy with it, we can make the change in 11.0.
https://github.com/dotnet/runtime/tree/reenableTerminalLogger
@jkotas @akoeplinger @ViktorHofer @ManickaP

Related https://github.com/dotnet/runtime/issues/94183 https://github.com/dotnet/runtime/issues/97211

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.