`ConnectionSetupDistributedTracing` is not trimmed when `EnableActivityPropagation=false`

Open

#117,545 opened on Jul 11, 2025 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: csharp
Domain: networking, observability, performance

Research direction

Read HttpConnectionWaiter.cs at the linked line and ConnectionSetupDistributedTracing.cs at its linked lines, then compare their usages with the EnableActivityPropagation check. Confirm that disabling the feature allows the related diagnostics code to be trimmed, and resolve whether the change belongs in the .NET 10 timeframe or Future as discussed in the issue.

Written by the indexing model from the issue text.

Description

area-System.Net.Http size-reduction

https://github.com/dotnet/runtime/blob/35584ab5b36abeb8a99607f8a32fa9f6468325d9/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/HttpConnectionWaiter.cs#L37

The usages of this type should be beyond a check against the GlobalHttpSettings.DiagnosticsHandler.EnableActivityPropagation variable/feature switch which we overlooked this type in our review of #114326.

Since the type constructs a static ActivitySource, I assume this prevents trimming out System.Diagnostics stuff that would be trimmed otherwise.

Should this be fixed for .NET 10 @pavelsavara? Or should it go to Future given #114635 is also postponed?

https://github.com/dotnet/runtime/blob/35584ab5b36abeb8a99607f8a32fa9f6468325d9/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectionPool/ConnectionSetupDistributedTracing.cs#L11-L15

Dominant language: C#
Stars: 18.3k
Forks: 5.6k
PR merge metrics: PR metrics pending

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Tsavorite.test fails to compile on main: TestBase.cs references Garnet.test.TestUtils, which is not linked into Tsavorite.test.csproj Open

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

microsoft/garnet#2161 · 2 comments · Opened Sep 20, 2026
v11 update: Validation attributes are no longer experimental Open

:watch: Not Triaged 11.0 fundamentals/subsvc

Difficulty 2/5 1-3 hours Newbie friendliness 92/100

dotnet/AspNetCore.Docs#37699 · Opened Sep 20, 2026
SE 5.3.0 beta 7: In Settings Video player download buttons aren't together Open

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

SubtitleEdit/subtitleedit#15108 · 1 comment · Opened Sep 20, 2026
Kubernetes get-started create-component.md: Go and C# silently default isMinikube instead of requiring it, unlike TS/Python/Java/HCL Open

area/docs-content Bug pulumi/docs

Difficulty 1/5 1-3 hours Newbie friendliness 94/100

pulumi/docs#21762 · Opened Sep 20, 2026
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

PowerShell/PSResourceGet#2056 · Opened Sep 20, 2026

More C# issues