Make DisasmCheck skip tests if certain environment variables are present

Open
#116,559 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
testing-qa

Research direction

Start by reviewing the DisasmCheck implementation and the behavior described in pull request 116441. Identify which environment variables should trigger skipping and how the existing checks are invoked. Done means those checks are skipped when the relevant variables are present, without requiring the variables to be manually restored for the check to pass.

Written by the indexing model from the issue text.

Description

area-CodeGen-coreclr

I am not sure how feasible it is, but we should skip DisasmChecks if certain environment variables are present. Today, like in https://github.com/dotnet/runtime/pull/116441, we have to just add back the environment variable to make sure the disasm check passes.

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.