WASM: browser-wasm * Release WasmBuildTests don't use hardcoded SDK version

Open
#116,451 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, wasm
Domain
build-system, testing

Research direction

Start by locating the Release WasmBuildTests and the SdkVersionForWorkloadTesting setting mentioned in the issue. Read the linked PRs and the global.json version used by codeflow to understand the current mismatch. Done means the tests no longer hardcode 9.0.105 and continue to use the intended SDK version after codeflow updates.

Written by the indexing model from the issue text.

Description

arch-wasm area-Workloads

https://github.com/dotnet/runtime/pull/114676 hardcoded SdkVersionForWorkloadTesting to 9.0.105, this is not good because it will break as soon as codeflow bumps the global.json version.

See: https://github.com/dotnet/runtime/pull/115677#issuecomment-2957080374 and
arcade codeflow CI: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1057438&view=logs&j=1fa93050-f528-55d3-a351-f8bf9ce5adbf&t=d9dc6d3d-3442-5b70-1296-5b62e29ea209&l=78

cc @ericstj

Dominant language
C#
Stars
18.3k
Forks
5.6k
Avg merge
2d 19h
Merged PRs (30d)
589

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.