BindingFlagSupport source is duplicated between CoreLib and System.Reflection.MetadataLoadContext

Open

#116,243 opened on Jun 3, 2025 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Stale
Tech stack: csharp
Domain: build-system

Research direction

Compare the BindingFlagSupport entries in src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj and src/libraries/System.Reflection.MetadataLoadContext/src/System.Reflection.MetadataLoadContext.csproj. First diff the referenced source to determine whether the copies have diverged, then inspect the project's common-source organization. Done means the implementations are reconciled and the duplicated source is placed in a shared location.

Written by the indexing model from the issue text.

Description

area-System.Reflection enhancement

In working on https://github.com/dotnet/runtime/pull/116080 I noticed that nativeaot Corelib has a copy of the same code that's in MetadataLoadContext

https://github.com/dotnet/runtime/blob/fcd197c9a4ea9def2049fdb302eede3e044fba5f/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj#L380-L393

https://github.com/dotnet/runtime/blob/fcd197c9a4ea9def2049fdb302eede3e044fba5f/src/libraries/System.Reflection.MetadataLoadContext/src/System.Reflection.MetadataLoadContext.csproj#L28-L41

We should diff this to see if it's diverged and reconcile if it has, then deduplicate and place in common.

cc @jkotas @MichalStrehovsky

Dominant language: C#
Stars: 18.3k
Forks: 5.6k
PR merge metrics: PR metrics pending

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Tsavorite.test fails to compile on main: TestBase.cs references Garnet.test.TestUtils, which is not linked into Tsavorite.test.csproj Open

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

microsoft/garnet#2161 · 2 comments · Opened Sep 20, 2026
v11 update: Validation attributes are no longer experimental Open

:watch: Not Triaged 11.0 fundamentals/subsvc

Difficulty 2/5 1-3 hours Newbie friendliness 92/100

dotnet/AspNetCore.Docs#37699 · Opened Sep 20, 2026
SE 5.3.0 beta 7: In Settings Video player download buttons aren't together Open

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

SubtitleEdit/subtitleedit#15108 · 1 comment · Opened Sep 20, 2026
Kubernetes get-started create-component.md: Go and C# silently default isMinikube instead of requiring it, unlike TS/Python/Java/HCL Open

area/docs-content Bug pulumi/docs

Difficulty 1/5 1-3 hours Newbie friendliness 94/100

pulumi/docs#21762 · Opened Sep 20, 2026
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

PowerShell/PSResourceGet#2056 · Opened Sep 20, 2026

More C# issues