EnC: Add support for updating ManifestResource table
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 28/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- compilers, developer-experience
Research direction
Begin with the EnC/Hot Reload implementation that handles metadata deltas and the ManifestResource table; the issue does not name files or tests. Reproduce by updating a .resx during an EnC session, then verify the three Assembly resource APIs return updated data without a restart and account for cache invalidation described in issue #115911.
Written by the indexing model from the issue text.
Description
Description
Adding, updating or deleting a managed resource during Hot Reload/EnC currently requires restarting the application. To avoid that we need the runtime to allow changes to ManifestResource table.
Embedded resources listed in the ManifestResource table are stored in the resource section of the PE file, at an offset stored in the ManifestResource table. Similarly to FieldRVA implementation, we can store the blob in the IL delta stream in EnC delta and interpret the offset as a position in the IL stream.
Once implemented a new EnC capability ChangeManifestResources should be added.
The resource string cache also needs to be invalidated when Hot Reload change is applied: https://github.com/dotnet/runtime/issues/115911
The following APIs should return the updated resources after change is applied:
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assembly.getmanifestresourceinfo?view=net-9.0
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assembly.getmanifestresourcenames?view=net-9.0
https://learn.microsoft.com/en-us/dotnet/api/system.reflection.assembly.getmanifestresourcestream?view=net-9.0
Any Reflection caches that store the data need to be invalidated on Hot Reload update.
Reproduction Steps
Update .resx file during Hot Reload/EnC session.
Expected behavior
The change is applied without restarting application.
Actual behavior
The change is ignored.
Regression?
No
Known Workarounds
No response
Configuration
No response
Other information
No response
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSResourceGet#2056 ·